Gilmour109/calchat
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: use pino err key for proper Error serialization in controllers

Browse Source 
Error objects logged as { error } were serialized as {} because pino
only applies its error serializer to the err key.
This commit is contained in:
Linus Waldowsky
2026-02-09 22:41:46 +01:00
parent 189c38dc2b
commit 5a9485acfc
3 changed files with 21 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
apps/server/src/controllers/EventController.ts
View File

@@ -18,7 +18,7 @@ export class EventController {
try {
await this.caldavService.pushEvent(userId, event);
} catch (error) {
log.error({ error, userId }, "Error pushing event to CalDAV");
log.error({ err: error, userId }, "Error pushing event to CalDAV");
}
}
}
@@ -28,7 +28,7 @@ export class EventController {
try {
await this.caldavService.deleteEvent(userId, event.caldavUUID);
} catch (error) {
log.error({ error, userId }, "Error deleting event from CalDAV");
log.error({ err: error, userId }, "Error deleting event from CalDAV");
}
}
}
@@ -40,7 +40,7 @@ export class EventController {
await this.pushToCaldav(userId, event);
res.status(201).json(event);
} catch (error) {
log.error({ error, userId: req.user?.userId }, "Error creating event");
log.error({ err: error, userId: req.user?.userId }, "Error creating event");
res.status(500).json({ error: "Failed to create event" });
}
}
@@ -57,7 +57,7 @@ export class EventController {
}
res.json(event);
} catch (error) {
log.error({ error, eventId: req.params.id }, "Error getting event");
log.error({ err: error, eventId: req.params.id }, "Error getting event");
res.status(500).json({ error: "Failed to get event" });
}
}
@@ -67,7 +67,7 @@ export class EventController {
const events = await this.eventService.getAll(req.user!.userId);
res.json(events);
} catch (error) {
log.error({ error, userId: req.user?.userId }, "Error getting events");
log.error({ err: error, userId: req.user?.userId }, "Error getting events");
res.status(500).json({ error: "Failed to get events" });
}
}
@@ -100,7 +100,7 @@ export class EventController {
res.json(events);
} catch (error) {
log.error(
{ error, start: req.query.start, end: req.query.end },
{ err: error, start: req.query.start, end: req.query.end },
"Error getting events by range",
);
res.status(500).json({ error: "Failed to get events" });
@@ -124,7 +124,7 @@ export class EventController {
res.json(event);
} catch (error) {
log.error({ error, eventId: req.params.id }, "Error updating event");
log.error({ err: error, eventId: req.params.id }, "Error updating event");
res.status(500).json({ error: "Failed to update event" });
}
}
@@ -171,7 +171,7 @@ export class EventController {
await this.deleteFromCaldav(userId, event);
res.status(204).send();
} catch (error) {
log.error({ error, eventId: req.params.id }, "Error deleting event");
log.error({ err: error, eventId: req.params.id }, "Error deleting event");
res.status(500).json({ error: "Failed to delete event" });
}
}